Skip to content

Conversation

@sid-srini
Copy link
Owner

Performed rebase and some squashing of Achal1607/final-java-notebook

sid-srini and others added 20 commits August 25, 2025 21:07
Overriding transitive dep brace-expansion version to 2.0.2.
Merge 'oracle:main' as on 2025-08-26

See merge request oci-jpg-jvsce/javavscode-cpu!3
Applying version recommendation
Sync changes for 24.1.1 on 20250917
Overriding transitive dep brace-expansion version to 2.0.2.
Sync 24.1.1 commits into main
- registers support
- save outputs
- classpath option
- code completions in the notebook
- recovers from out-of-order cell state changes

Note: notebooks module in nbcode
Uses RequestProcessor for async Jshell init and code eval
- Structure validation using nbformat schema
- Updated licenses and copyright
- Added proper id to each cell
- Added proper execution count
- Added validation in serialization step
- Added logs

Co-authored-by: Achal Talati <[email protected]>
- added input output stream support
    - added streaming support of cell execution, enhanced output stream
    - added protocol for listening to cell execution notifications
    - added streaming support in the frontend for notebooks and improved kernel
- added interrupt handler
- added cellId to be passed in the cell execution request
- added jshell context in the editor context
- fixed issue of command truncation
- improved code completion provider
- fixed some build issues and bugs, e.g. init of configurations
- Corrected execution counter
- Introduced mimeTypeHandler and executionSummary and refactored code
- Added new commands to localisation english file
- Added tests for mimeType and executionSummary of notebook code
- New and unexecuted cells will not display success or failure
1. Added mock lsp client helper class
2. Added test for NotebookConfigs class
3. Updated test dependency in project.xml
- Added opening notebooks in context of a project
    - Also added change project context button in the notebook toolbar
    - Added few more tests
- Added localization in notebooks
- Fixed jshell flow and updated open jshell label
- Other cleanup and fixes
    - updated netbeans patch
    - cleanup of some unused code and added license header to missing files
    - formatted files and removed unused imports
    - updated ajv to latest version: 8.17.1
    - updated artifactory urls
    - fixed the execution status issue
    - removed console.log and replaced with standard extension logger
- Addressed review comments
- Fixed some labels
- Improvements to NotebookUtils for conversions between line-based positions and string offsets
    - Avoiding unnecessary string split and joins
    - Added unit tests
- Notebook configurations related changes
    1. Made classpath,modulepath and add modules configs as array type on frontend
    2. Corresponding changes on backend to process the array
    3. Updated notebook configs unit tests
- Add enable-preview flag from the project context if not configured
- Addressed minor gaps in notebook cell execution
    - Correctly printing the runtime errors stacktrace
    - Handling null output stream callback
    - Performing lineEnding normalization only where required in cell setContent.
    - Minor performance improvements

Co-authored-by: Achal Talati <[email protected]>
Co-authored-by: Shivam Madan <[email protected]>
Co-authored-by: Siddharth Srinivasan <[email protected]>
@sid-srini sid-srini force-pushed the rebased-final-java-notebook branch from 7352aad to 4a46f1c Compare September 29, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants