forked from oracle/javavscode
-
Notifications
You must be signed in to change notification settings - Fork 0
Rebased final java notebook #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sid-srini
wants to merge
20
commits into
main
Choose a base branch
from
rebased-final-java-notebook
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overriding transitive dep brace-expansion version to 2.0.2.
Merge 'oracle:main' as on 2025-08-26 See merge request oci-jpg-jvsce/javavscode-cpu!3
Applying version recommendation
Sync 24.1.1 20250909
Sync changes for 24.1.1 on 20250917
Overriding transitive dep brace-expansion version to 2.0.2.
Sync 24.1.1 commits into main
- registers support - save outputs - classpath option - code completions in the notebook - recovers from out-of-order cell state changes Note: notebooks module in nbcode
Uses RequestProcessor for async Jshell init and code eval
- Structure validation using nbformat schema - Updated licenses and copyright - Added proper id to each cell - Added proper execution count - Added validation in serialization step - Added logs Co-authored-by: Achal Talati <[email protected]>
- added input output stream support
- added streaming support of cell execution, enhanced output stream
- added protocol for listening to cell execution notifications
- added streaming support in the frontend for notebooks and improved kernel
- added interrupt handler
- added cellId to be passed in the cell execution request
- added jshell context in the editor context
- fixed issue of command truncation
- improved code completion provider
- fixed some build issues and bugs, e.g. init of configurations
- Corrected execution counter - Introduced mimeTypeHandler and executionSummary and refactored code - Added new commands to localisation english file - Added tests for mimeType and executionSummary of notebook code - New and unexecuted cells will not display success or failure
1. Added mock lsp client helper class 2. Added test for NotebookConfigs class 3. Updated test dependency in project.xml
- Added opening notebooks in context of a project
- Also added change project context button in the notebook toolbar
- Added few more tests
- Added localization in notebooks
- Fixed jshell flow and updated open jshell label
- Other cleanup and fixes
- updated netbeans patch
- cleanup of some unused code and added license header to missing files
- formatted files and removed unused imports
- updated ajv to latest version: 8.17.1
- updated artifactory urls
- fixed the execution status issue
- removed console.log and replaced with standard extension logger
- Addressed review comments
- Fixed some labels
- Improvements to NotebookUtils for conversions between line-based positions and string offsets
- Avoiding unnecessary string split and joins
- Added unit tests
- Notebook configurations related changes
1. Made classpath,modulepath and add modules configs as array type on frontend
2. Corresponding changes on backend to process the array
3. Updated notebook configs unit tests
- Add enable-preview flag from the project context if not configured
- Addressed minor gaps in notebook cell execution
- Correctly printing the runtime errors stacktrace
- Handling null output stream callback
- Performing lineEnding normalization only where required in cell setContent.
- Minor performance improvements
Co-authored-by: Achal Talati <[email protected]>
Co-authored-by: Shivam Madan <[email protected]>
Co-authored-by: Siddharth Srinivasan <[email protected]>
7352aad to
4a46f1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performed rebase and some squashing of Achal1607/final-java-notebook